yonaskolb / XcodeGen

A Swift command line tool for generating your Xcode project
MIT License
7.03k stars 818 forks source link

Ignore renamed Info.plist files #207

Open yonaskolb opened 6 years ago

yonaskolb commented 6 years ago

At the moment Info.plist files are treated differently in that they don't get added to the Resources build phase. We should change this to check a target's various levels of build settings for INFOPLIST_FILE, and ignore what is in that setting as some projects may use a different name than Info.plist

yonaskolb commented 6 years ago

I wonder if it's worth creating an actual infoPlist property on Target for easily setting this build setting?

toshi0383 commented 6 years ago

infoPlist property on Target

I would suggest users to set INFOPLIST_FILE somewhere explicitly, rather than introducing infoPlist property on project.yml. That's how it works anyways. And this infoPlist property possibly conflicts with INFOPLIST_FILE settings. We're already doing implicit Info.plist detection, so implementability of this part would become worse I guess.