search

yonat / MultiSlider

UISlider clone with multiple thumbs and values, range highlight, optional snap intervals, optional value labels, either vertical or horizontal.
MIT License
494 stars 113 forks source link

Initial value doesnot show positiveSuffix #36

Closed shubham14896 closed 4 years ago

shubham14896 commented 4 years ago

Description of the problem: [description]

Minimal project that reproduces the problem (so I'll be able to figure out how to fix it): [github repo or a zipped project]

yonat commented 4 years ago

Good catch! Fixed in version 1.10.2.

jstoppenbach commented 4 years ago

This update introduces a crash with iOS 10. The App crashes when the MultiSlider is deallocated. "An instance 0x17b97d80 of class NSNumberFormatter was deallocated while key value observers were still registered with it."

yonat commented 4 years ago

True. It seems removeObserver() is completed only after the old formatter is discarded, and not synchronously.

I disabled the fix for iOS < 11, so in 1.10.4 you will have neither the crash nor the fix on old iOS versions.