search

yonatan-mitmit / onium

Extension injector into Electron apps
MIT License
21 stars 3 forks source link

doesn't work #7

Closed chocolate012 closed 4 years ago

chocolate012 commented 4 years ago

I installed it but the app is still not RTL anyway to debug or how to go about it?

cr-mitmit commented 4 years ago

Slack had a minor release yesterday that broke the RTL fix. I updated Onium to support the most recent version.

Please try again.

chocolate012 commented 4 years ago

yes it works Thanks

chocolate012 commented 4 years ago

Is there any way I can contact you?

cr-mitmit commented 4 years ago

Through here is ideal.

chocolate012 commented 4 years ago

I was wondering if you can take this another step and add Hebrew in the app for the menus and other builtin wordings

cr-mitmit commented 4 years ago

Likely possible to replace individual words, but it's likely a lot of work. Not sure I understand the motivation - can you elaborate?

chocolate012 commented 4 years ago

We just started using Slack in our Non-Profit organization and a lot of the members will feel more comfortable if we can have Slack in Hebrew

cr-mitmit commented 4 years ago

Sorry. I don't see any chance to undertake such a large project anytime soon. If you have the programming skills, I can point you to what needs to be done.

chocolate012 commented 4 years ago

I don't have but if you can point me in the right direction. it will be easier to find someone Thanks

--

On Fri, 26 Jun 2020 at 23:48, cr-mitmit notifications@github.com wrote:

Sorry. I don't see any chance to undertake such a large project anytime soon. If you have the programming skills, I can point you to what needs to be done.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/yonatan-mitmit/onium/issues/7#issuecomment-650393848, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFARSPDYT3JLD666FDSYPLRYUCRPANCNFSM4NSUJVAQ .

cr-mitmit commented 4 years ago

Onium allows running with -d which allows a chrome process to debug it. Run onium -d and then launch slack and chrome. In Chrome browse to http://localhost:9222/ and then you can see the raw "code" of the page.

At that point you need to find the text and change onium's code.py to modify the slack program.

chocolate012 commented 4 years ago

If I understand correctly this will only allow me to modify the wordings within the Slack app but not the words that are within Slack, correct?

cr-mitmit commented 4 years ago

It allows you to modify the code (technically html+js code) running in the app. This allows you to modify the entire slack user interface.