yonghah / esri2sf

Scrape features from ArcGIS Server REST API and create simple features dataframe
Other
138 stars 37 forks source link

Make esri url checks more general #40

Closed jacpete closed 2 years ago

jacpete commented 2 years ago

Purpose: Adapt esriUrl_isValid to accept valid, but non-service/feature URL's like the root of a server or a folder page like https://sampleserver1.arcgisonline.com/ArcGIS/rest/services/Demographics or https://sampleserver1.arcgisonline.com/ArcGIS/rest/services

Deprecated/Renamed Exported Functions:

Added Functions:

Changed Functions:

jacpete commented 2 years ago

@elipousson Here is what I am pulling together to fix the esriUrl_isValid issues in #39 . I want to go a little deeper and make sure everything is still working correctly in some of the functions that don't have tests built for them yet. Main thing is a major update to generalize esriUrl_isValid, but I also made some slight changes in the output of esriUrl_parseUrl and changed a couple function names. The function names I changed I just did a simple wrapper around the original function with a deprecation warning. This will be what we use if we decide to change standardize function names in the package. Feel free to download the branch and play with it to see if it will work with your idea of the esriIndex function.