search

yongjhih / docker-parse-server

Provide docker images and docker stack for parse-server npm versions and latest commit
https://hub.docker.com/r/yongjhih/parse-server/
Apache License 2.0
475 stars 166 forks source link

PARSE_DASHBOARD_SERVER_URL not get value from params #42

Closed katopz closed 8 years ago

katopz commented 8 years ago

refer to https://github.com/yongjhih/docker-parse-server/blob/master/docker-compose.yml#L113 I think it should be 

PARSE_DASHBOARD_SERVER_URL = $PARSE_DASHBOARD_SERVER_URL

so it can set from external params, or maybe I miss something here?

katopz commented 8 years ago

Also https://github.com/yongjhih/docker-parse-dashboard/blob/master/docker-compose.yml#L13 should except it too

PARSE_DASHBOARD_SERVER_URL: $PARSE_DASHBOARD_SERVER_URL
yongjhih commented 8 years ago

The parse-dashboard did not have a default value for serverUrl, so you can not ignore SERVER_URL anymore while docker-compose starting:

SERVER_URL=xxx MASTER_KEY=mmm APP_ID=aaa docker-compose up

And PARSE_DASHBOARD_SERVER_URL is docker inner env var for parse-dashboard program, I design a global/unique var naming SERVER_URL for docker stack.