yongmingyang / pe

0 stars 0 forks source link

Diagram is too small, and arrows are everywhere #11

Open yongmingyang opened 3 years ago

yongmingyang commented 3 years ago

I refer to page 7/53 of the Developer Guide.

image.png

As shown, the image is very condensed, and there's too much going on at once. Furthermore, upon zooming in, the arrows are all over the diagram, making it highly unreadable, especially when the arrows cross paths with each other. It could be better to separate the different parts of the diagram into individual images.

nus-se-bot commented 3 years ago

Team's Response

Too much details: Class diagram requires detailed illustration of the inner workings of the class. The amount of detail is similar to the one in address book's DG as well. The details shown are all necessary to guide the reader about the logic class.

Arrows are all over diagram and image size is too small: We tried to change this but unfortunately, due to PLANTUML's limitation we are unable to rectify this. Perhaps zooming in will aid in making the image size bigger and widen spaces between arrows. This is a valid solution because the image is still clear even after zooming in.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I don't see why this issue should be classified as NotInScope


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]