search

yongmingyang / pe

0 stars 0 forks source link

Unable to find items with empty tag or empty supplier #7

Open yongmingyang opened 3 years ago

yongmingyang commented 3 years ago

Steps to reproduce: 1) Open jar file 2) Add items with tag 3) Add same item without tag 4) Add item with supplier 5) Add same item in 4) without supplier 6) Type in command below:

find-i n/Milk s/

Expected: "1 item listed"

Actual:

image.png

This is similar for with and without tag. This means that items with no supplier or tag indicated cannot be found by itself.

nus-se-bot commented 3 years ago

Team's Response

Tester misunderstood the functionality of our application. It is not mentioned in our UG that they can find items without tags or suppliers, as it is not realistic in terms of use case to the restaurant owners. If restaurant owners would want to find something in the future with that particular item, then it should be tagged with something in the first place.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I don't think that I misunderstood the functionality of the application. Consider the following scenario as a restaurant owner:

1) My inventory is filled with a thousand different items already 2) My staff orders a certain ingredient but did not tell me the supplier. Due to my busy schedule, I add the ingredient into stock first, and I'll update the supplier later on, after clarification with my staff. 3) While waiting for my staff to update me, I add various other items to the list 4) My staff has now updated me about the supplier's name, upon trying to find the ingredient, nothing shows up!! 5) I now have to scroll through the entire list to find that particular ingredient without a supplier's tag.

Furthermore, if ingredients can be added without a tag/supplier, it only makes sense that they should be able to be found. Additionally, if the item was added accidentally without finishing the command, it is possible that tag/supplier field has not been filled up.

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FeatureFlaw]

Reason for disagreement: Not a documentation bug. This bug is due to the feature implementation and should be a feature flaw, there was no misunderstanding of the documentation.

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: It is likely to affect users (restaurant owners) occassionally, causing them inconvenience and it is very time consuming to have to scroll through to find the particular item without a supplier/tag. It may not affect most users or make it unusable, but I think that it may still cause inconvenience occassionally. Hncee, I think if severity is to be lowered, it should be lowered to medium at most.