search

yongqyu / MolGAN-pytorch

Pytroch implementation of MolGAN: An implicit generative model for small molecular graphs (https://arxiv.org/abs/1805.11973)
161 stars 42 forks source link

test function has a undefined/unused variable #5

Open violetguos opened 4 years ago

violetguos commented 4 years ago

Hi,

While attempting to run test(), I noticed that

the log variable is undefined in solver.py https://github.com/yongqyu/MolGAN-pytorch/blob/8a22b864c3c9b7118c9317b57442045c524c1d81/solver.py#L392 this log variable in line 392 referenced above is never printed or saved to a log_dir.

yongqyu commented 4 years ago

sorry for late answer. And thank you for your point. The code for this part is wrong. I can't fix it right away, so I'll leave this issue unclosed.

Thank you for your interest in my code.

Wenjian-Ma commented 4 years ago

Hi,

While attempting to run test(), I noticed that

the log variable is undefined in solver.py https://github.com/yongqyu/MolGAN-pytorch/blob/8a22b864c3c9b7118c9317b57442045c524c1d81/solver.py#L392

this log variable in line 392 referenced above is never printed or saved to a log_dir.

Just delete "+",then print(log), like this: log = ", {}: {:.4f}".format(tag, value) print(log)