yongxiangng / pe

0 stars 0 forks source link

UserGuide does not mention that I'm not allowed to add person of similar name #4

Open yongxiangng opened 2 years ago

yongxiangng commented 2 years ago

image.png

I see that the team treats Alex Yeoh the same as alex yeoh. Which I'm fine (as the module website does talk about this as well). However, I think this behavior should be documented somewhere, maybe in the UserGuide, or have a different kind of error message instead (a warning).

image.png

The module recommends that the decision be left to the user, but have them know the risks with a warning message.

Honestly, I'm not sure what category this bug report should be under, I think it can be fixed in many ways, just better to be explicit (plz don't change the bug type unless you really think there's an issue).

nus-se-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add / edit different persons

I am unable to add another person with the same name into the app.

Steps to reproduce:

  1. run the command add n/Jane Doherty p/1847291074 e/janedoe123@gmail.com a/Coral Street, 5th Avenue, #02-04, pr/500.00 i/ s/pending t/caterer
  2. run the command add n/Jane Doherty p/98765432 e/jennyD@gmail.com

Expected: Entry in point 2 can be added since they are different persons as evidenced by their different phone numbers and email addresses Actual: App identifies person in point 2 to be the same as person in point 1.

image.png


[original: nus-cs2103-AY2122S1/pe-interim#1909] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is specified in the user guide in the following sentence, "Since a wedding can be big and two or more people might come from the same family, all contact information (other than the contact's name) can be duplicated.".

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This isn't the same issue. The "duplicate" of mine questions why the application doesn't allow for 2 people of the same name, case sensitive (this sounds like the tester just trying to crap his way and maliciously report).

My bug report questions why the case insensitive part isn't documented properly in the DG. I am in complete favor of the team banning duplicate name (case sensitive). But in the case where they are same (case insensitive), they should either leave it to the user with a warning, or document it.

My bug report is reasonable, but the duplicate's is just unreasonable and I don't want to be associated to that unreasonable bug report (because I received such reports and it's frustrating).

Essentially the duplicate is questioning the team's choice, while I am questioning the team's documentation. These are different things, the duplicate's report is subjective, while mine is objective.


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: My bug report questions why the case insensitive part isn't documented properly in the DG. I am in complete favor of the team banning duplicate name (case sensitive), that's completely reasonable. But in the case where they are same (case insensitive), they should either leave it to the user with a warning, or document it.


:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.DocumentationBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]