yonicd / covrpage

Create a summary readme for the testthat subdirectory to communicate with potential users
https://yonicd.github.io/covrpage/
Other
52 stars 7 forks source link

problems displaying icons properly on a windows machine #22

Closed IndrajeetPatil closed 5 years ago

IndrajeetPatil commented 5 years ago

Pretty sure this is an issue about the Unicode handling in R (under windows). This is what the README page looks like: https://github.com/IndrajeetPatil/ggstatsplot/tree/master/tests

1. image

2. image

3. image

yonicd commented 5 years ago

nice! i'll try to figure something out.

yonicd commented 5 years ago

digging into this a bit it looks like rmarkdown isnt rendering the unicode. the unicode is being read in right.

this is the warning icon in windows

yonicd commented 5 years ago

until issue is resolved in rmarkdown.

windows OS (based on .Platform[['OS.type']]) will have characters instead of icons.

https://github.com/yonicd/covrpage/commit/ac873f6fde2e9f7a43805b567fb54d0f51c10d79

Failed Warning Skipped
! - +
IndrajeetPatil commented 5 years ago

Sorry, couldn't get back to you on Twitter about this. Busy day.

Yeah, this looks good as a temporary solution!

yonicd commented 5 years ago

For a endlessly long discussion on the issue (sink()). See here