Closed yonicd closed 5 years ago
it would be more than that, I'm wondering whether it could "just" take over the current use_covrpage()
, because travis::use_tic()
also helps with:
GITHUB_PAT
just for TravisSo there could be
covrpage
.covrpage
command.GITHUB_PAT
is great for GITHUB
repos, but users are also using GHE
, which needs a different PAT
, how does tic handle that?
@krlmlr does tic
handle GitHub Enterprise? I don't think so?
I have never tried. But since tic can execute arbitrary R code, I'm confident a solution can be worked out with add_code_step()
, and maybe later integrated if necessary.
does tic have a way to encrypt a local environmental variable for appveyor? the ghe token is different than the gh token.
Have you seen https://www.appveyor.com/docs/build-configuration/#secure-variables? Currently we don't have a way to do this automatically.
Yes. I did that for a repo once, was wondering if it’s possible in tic somehow. Thanks for the link.
What I did to get covrpage
README and vignette deploying for pRojects
(not fully there yet...)
covrpage
to Suggests and Remotes. When/if covrpage
gets to CRAN, only Suggests will be needed.get_stage("after_success") %>%
add_code_step(covr::codecov()) %>%
add_code_step(devtools::install()) %>%
add_code_step(covrpage::covrpage_ci())
(covrpage
needs the package to be installed)
and
if (ci()$get_branch() == "master") {
get_stage("deploy") %>%
add_step(step_push_deploy(commit_paths = "tests/README.md")) %>%
add_step(step_build_pkgdown()) %>%
add_step(step_push_deploy(path = "docs", branch = "gh-pages"))
}else{
get_stage("deploy") %>%
add_step(step_push_deploy(commit_paths = "tests/README.md"))
}
instead of just the pkgdown
usual stuff. It doesn't work yet because "tests/README.md" is staged, there's nothing to commit, then there's a message saying it was modified but not staged. I'm a bit lost at the moment.
I'm not sure how this should be documented in covrpage
when it works.
use_tic()
wrapper with its own tic.R but hard to keep that updated.Now it works see https://github.com/lockedata/pRojects/blob/master/tic.R
I tried to set it up using this branch. I am still confused on how to use tic. Currently it is still not deploying.
is it deploying now?
and if it is, what's your view now on a re-factoring of use_covrpage
?
It is deploying now. I think that I'll keep it as an option and not as the default. so users can choose their comfort zone yml/tic/bash
I'll let you handle this, then? Seems easier given how well you know use_covrpage()
😉
added use_tic in use_covrpage. @maelle do the steps in use_tic make sense?
It looks good!
add to use_covrpage and option to build a tic.R file and a travis.yml that has
tic
dependency.