search

yonicd / covrpage

Create a summary readme for the testthat subdirectory to communicate with potential users
https://yonicd.github.io/covrpage/
Other
52 stars 7 forks source link

covrpage installation #53

Closed maelle closed 5 years ago

maelle commented 5 years ago

:wave: any idea why I get https://travis-ci.org/maelle/trying.lockedata.starters/builds/480813189#L2111 ?

It's supposed to get installed before getting used cf https://github.com/maelle/trying.lockedata.starters/blob/master/tic.R

yonicd commented 5 years ago

what version of remotes are you using?

remotes::install
Error: 'install' is not an exported object from 'namespace:remotes'
> packageVersion('remotes')
[1] ‘1.1.1’
maelle commented 5 years ago

:woman_facepalming: thank you!

maelle commented 5 years ago

I still get an error though https://travis-ci.org/maelle/trying.lockedata.starters/builds/480819409

maelle commented 5 years ago

maybe I should not use "::" because tic tries to install covrpage despite my installing it?

maelle commented 5 years ago

Note that I wouldn't want covrpage to be listed in DESCRIPTION.

yonicd commented 5 years ago

you shouldnt need it in the DESCRIPTION. it can be placed in the 

r_github_packages:
- metrumresearchgroup/covrpage

not sure the tic equiv of that

maelle commented 5 years ago

new error :thinking: https://travis-ci.org/maelle/trying.lockedata.starters/builds/480830490#L2064

yonicd commented 5 years ago

does it run locally on the repo clone?

maelle commented 5 years ago

good idea, will test.

yonicd commented 5 years ago

covrpage will not complete if testthat doesnt fully complete. if i remember correctly if testthat sees too many failures it stops the whole process.

maelle commented 5 years ago

that can't be the problem, I only have a dummy test checking that 2*2==4 :joy_cat:

yonicd commented 5 years ago

here is a branch that should solve your issue. when you have time test it and i'll merge it into master