yonicd / slickR

slick carousel htmlwidget for R
https://yonicd.github.io/slickR/
Other
158 stars 14 forks source link

Get unit tests passing with htmlwidgets 1.6 #68

Closed cpsievert closed 1 year ago

cpsievert commented 1 year ago

htmlwidgets 1.6 (soon to be released) adds a fill parameter to sizingPolicy(), which causes some unit tests to fail (since they are snapshotting the entire htmlwidget object).

This PR does the minimum to update the unit tests so they pass with htmlwidgets 1.6 (by simply updating the rds files), but you may want to consider using testthat::expect_snapshot() since that will make the changes to these objects more transparent. You may also want to consider using something like {shinytest2} and/or {webshot2} to make sure the widgets actually render in the browser.

I plan on submitting htmlwidgets 1.6 within the next couple weeks. If you could please submit this patch fix to CRAN before then, it'd be much appreciated.