search

yonilerner / cs2-retakes-allocator

Advanced weapon allocation for B3none/cs2-retakes
GNU General Public License v3.0
58 stars 16 forks source link

Command System Remake #141

Open GL1TCH1337 opened 6 months ago

GL1TCH1337 commented 6 months ago

I have removed player chat event based command system and integrated it to CS# command system. By doing this players can change prefix of command by CS# settings and no need to add different prefixes to this plugin config.

This also completely solves issue #128

Since this is a big change. Server owners should configure their config by new default config.

Waiting your feedbacks.

yonilerner commented 6 months ago

I need some time to think about this. Im not sure this is really necessary, maybe I'm not understanding though

yonilerner commented 6 months ago

This PR is more "standard" but it gives less flexibility to the commands themselves, so Im hesitant to change it. Does CS# support case insensitive commands maybe?

GL1TCH1337 commented 6 months ago

CS# command system commands work case insensitive. It will work anyways. !GuNs or !GUNS dont matter.

(another plugin of me but uses cs# command system)

image image image

oqyh commented 6 months ago

CS# command system commands work case insensitive. It will work anyways. !GuNs or !GUNS dont matter.

(another plugin of me but uses cs# command system)

image image image

you removing "gunmenu" ".gunmenu" some people want it without !

oqyh commented 6 months ago

if you want to solve https://github.com/yonilerner/cs2-retakes-allocator/issues/128 you can just change

if (CenterMenuCommands.Any(cmd => cmd.Equals(message, StringComparison.OrdinalIgnoreCase))) to if (CenterMenuCommands.Any(cmd => cmd.Equals(message.TrimStart('/'), StringComparison.OrdinalIgnoreCase)))