yookoala / gofast

gofast is a FastCGI "client" library written purely in go
BSD 3-Clause "New" or "Revised" License
224 stars 49 forks source link

possible fix of invalid memory address dereference (#74 and #48) #76

Closed marcel-dancak closed 2 years ago

marcel-dancak commented 2 years ago

I was experiencing occasional segmentation violation crashes, mostly during load tests with wrk. It happened only sometimes, so it's hard to reproduce it with 100% success, but I think I finally get rid off all crashes with this simple change in code.

yookoala commented 2 years ago

Seems to be a reasonable fix. Even if it doesn't fix anything, it doesn't break any current code or interface. Worth a try.

Thanks!