search

yoonkim / CNN_sentence

CNNs for sentence classification
2.05k stars 827 forks source link

other datasets #18

Closed alex-j-j closed 8 years ago

alex-j-j commented 8 years ago

When the code is used with a different dataset than the provided one it crashed if the longest sentence in the other dataset is longer than the longest sentence in the provided dataset. This can be fixed easily, the max length it set in the code manually.

HimaVarsha94 commented 8 years ago

But it is crashing when the test_model_all function is being called. How do I fix it?

alex-j-j commented 8 years ago

I deleted the code a long time ago. However, to deal with longer sentences you either have to increase the maximum length expected, or to pad the sentences to the already used maximum length. I will close the issue. Good luck.