search

yoonwaiyan / stackskills-dl

Simple Ruby script to download all StackSkills tutorials.
https://yoonwaiyan.github.io/stackskills-dl/
MIT License
59 stars 19 forks source link

stackskills-dl not working for multi-page lists of courses. #35

Closed Datadelvers closed 6 years ago

Datadelvers commented 6 years ago

Hello,

I am regular user of the stackskills-dl script, but recently I have run into a problem. When downloading courses I have purchased all works well if the course can be found on 'https://stackskills.com/courses/enrolled'. But I noticed that courses on the second page of courses 'https://stackskills.com/courses/enrolled?page=2' can't be downloaded.

Would it be possible to implement this feature?

Regards,

Daniel

yoonwaiyan commented 6 years ago

Hi @Datadelvers , this scripts supports multiple pages of courses. It's possible that they have changed their UI and I'm not aware of it. Let me check and get back to you with a bug fix if that's the case. Thanks for reporting.

Datadelvers commented 6 years ago

Thanks for the quick reply. Looking forward to a fix/workaround :+1:

yoonwaiyan commented 6 years ago

Hi @Datadelvers , are you trying to download courses from page 2 by using the -c or -s option or without any option?

yoonwaiyan commented 6 years ago

Found out a bug that cause courses couldn't be found when it's listed beyond first page when the options mentioned above is used. @Datadelvers please let me know whether this fix helps.

Datadelvers commented 6 years ago

@yoonwaiyan , I use the '-c' option. Now, lets try the fix.

Datadelvers commented 6 years ago

@yoonwaiyan , the fix allows courses beyond the first page to be downloaded as well. Perfect :-)