yoonwaiyan / stackskills-dl

Simple Ruby script to download all StackSkills tutorials.
https://yoonwaiyan.github.io/stackskills-dl/
MIT License
59 stars 19 forks source link

Updated video download scraping #7

Closed danifunker closed 7 years ago

danifunker commented 7 years ago

Looks like StackSkills changed their URL in the download links, it's now from filepicker.io, so I've updated that

Resolves the issue I identified yesterday.

yoonwaiyan commented 7 years ago

Sorry for the late review. It appears that one of my course that works with .mp4 all the time doesn't work anymore if we use filepicker.io while still works using .mp4. I think it's better to make filepicker.io as one of the fallback option so that the method can try links with filepicker.io if there's no mp4 links being returned.

Hope you can improve the code further to still cater for links with mp4 so that I can merge it. This might solve part of the problem as mentioned in #4 too. Thanks a lot.