Improved concordance method

Euak commented 5 years ago

Hello, @yooper ! @thiagogomesverissimo and I worked some things on the concordance method.

We uncoupled concordance function. We created: a method that only returns the positions of the needle in the text; a method that marks a needle in a string and a method that returns an excerpt from a string.
Improved the regex used to find the needle. Changed negated set to negative lookahead and lookbehind. This way it will capture correctly groups at the beginning of the string and at the end of the string without the need to add spaces.
And fixed the text variable so it won't convert a string with ISO-8859-1 if the method

If you have any questions or suggestions, feel free to ask me or @thiagogomesverissimo . Thank you.

yooper commented 5 years ago

Thanks, I will check it out this week and get back to you.

yooper commented 5 years ago

Thanks for the contribution

thiagogomesverissimo commented 5 years ago

Nice @yooper :wolf:

yooper / php-text-analysis