search

yooper / php-text-analysis

PHP Text Analysis is a library for performing Information Retrieval (IR) and Natural Language Processing (NLP) tasks using the PHP language
https://github.com/yooper/php-text-analysis/wiki
MIT License
527 stars 87 forks source link

Added support for wamania/php-stemmer ^2 and ^3 #74

Closed evertharmeling closed 1 year ago

evertharmeling commented 1 year ago

As it looks like warmania/php-stemmer is only used here. Adding support for v2 and v3 shouldn't be of high impact.

Also don't see any major changes from current support v1 vs v3 (diff).

Adding the support for newer versions makes the library a bit more flexible/usable :)

yooper commented 1 year ago

Thank you for the contribution, I will run the tests to verify compability and merge in the next couple days, if it all works.

yooper commented 1 year ago

I merged your change in. It did require code changes. Luckily it did not require much re-work.

evertharmeling commented 1 year ago

Ah sorry, missed the dynamic buildup of the namespace, nice work! ♥️