search

yooper / php-text-analysis

PHP Text Analysis is a library for performing Information Retrieval (IR) and Natural Language Processing (NLP) tasks using the PHP language
https://github.com/yooper/php-text-analysis/wiki
MIT License
527 stars 87 forks source link

FreqDist::getKeyValuesByWeight #76

Open massadm opened 1 year ago

massadm commented 1 year ago

https://github.com/yooper/php-text-analysis/blob/9b96d252f334f8ee35e067a0c7a40c24dc87a01d/src/Analysis/FreqDist.php#L119-L124

Perhaps there is a mistake.

array_walk: If the optional third parameter is supplied, it will be passed as the third parameter to the callback funcname.

So, $weightPerToken inside callback is just $this->totalTokens not $this->getWeightPerToken().

yooper commented 1 year ago

It has been awhile since I worked on the code base. Can you provide an example that tests the differences in your suggestion and provide the information here in this issue?

Thank you