yorickpeterse / nvim-window

Easily jump between NeoVim windows.
Mozilla Public License 2.0
107 stars 11 forks source link

After jump callback feature for nvim-window #8

Closed jamylak closed 7 months ago

jamylak commented 7 months ago
yorickpeterse commented 7 months ago

@jamylak nvim-window's purpose is to just switch windows, nothing more and nothing less. So what exactly is the use-case here that can't be addressed using autocmd events, such as TermEnter or WinEnter?

yorickpeterse commented 7 months ago

I just realized these changes are even more redundant: the pick method is synchronous, so if you need some kind of "after" hook you can just do this in your mapping like so:

vim.keymap.set(..., function()
  require('nvim-window').pick()
  ... after logic here ...
end)

As such I'm going to close this pull request.

jamylak commented 7 months ago

I just realized these changes are even more redundant: the pick method is synchronous, so if you need some kind of "after" hook you can just do this in your mapping like so:

vim.keymap.set(..., function()
  require('nvim-window').pick()
  ... after logic here ...
end)

As such I'm going to close this pull request.

oh cool completely missed that will try it