Addressing an insecure rendering issue when used in the Safari browser

yorickshan / html2canvas-pro

Screenshots with JavaScript. Next generation!

http://yorickshan.github.io/html2canvas-pro/

MIT License

103 stars 8 forks source link

Addressing an insecure rendering issue when used in the Safari browser #3

Closed daniel-rubicon closed 4 months ago

daniel-rubicon commented 4 months ago

Incorporating a change that was proposed for the base html2canvas library.

https://github.com/niklasvh/html2canvas/pull/2911

Thank you for your color function modifications to help bolster this library!

yorickshan commented 4 months ago

Perhaps it is not necessary to make changes to .gitignore and package-lock.json.

daniel-rubicon commented 4 months ago

The package-lock.json change was mainly running the npm audit --fix command to address some potential vulnerabilities.

The .gitignore change was to include the dist files, which I needed in order to be able to include the branch and build my app against it. There is likely a better way of doing this but I don't know the specific path

yorickshan commented 4 months ago

fixed in v1.5.1