search

yorikvanhavre / BIM_Workbench

A BIM Workbench for FreeCAD
363 stars 77 forks source link

Further tweaks to BIM WB icons #142

Closed marcuspollio closed 7 months ago

marcuspollio commented 7 months ago

Following @maxwxyz tweaks, make some more icons 64px based and use a consistent outline. Also fix some issue with Slab icon.

yorikvanhavre commented 7 months ago

Great! However:

  1. The white icons are meant for the tree. So they display at 16x16px. That's the reason why they have a larger outline. Might be good to check first how it looks
  2. In the BIM WB, doors and windows are separate. So an icon combining a door and a window is misleading
marcuspollio commented 7 months ago

Hi @yorikvanhavre ,

  1. Sorry, I'm confused : I only changed some Toolbar icons, so it should not affect the Tree, right ? See below the before and after:

BIM-icons-before-after

  1. In the BIM Workbench, doors and windows are separate indeed, which is great and better than the Arch WB in that regard. However, the Manager still have them combined, see below. Do you intend to separate the manager too ? In that case, I can provide 2 separate icons.

BIM-icons-windows-doors

yorikvanhavre commented 7 months ago

Hmm indeed it's you who was right and me who was wrong :) Sorry! All makes sense then. I'll merge!

marcuspollio commented 7 months ago

@yorikvanhavre No worries at all ! =D

Thank you for merging !

Let me know if you need other icons tweaks, new icons for future Ifc Classes, or separate Windows and Doors "Managers" ;D