search

yoriyuki / Camomile

A Unicode library for OCaml
Other
125 stars 26 forks source link

made CamomileDefaultConfig visible to users #1

Closed rgrig closed 11 years ago

rgrig commented 12 years ago

Suppose a user wants to redefine how data files are searched, but would like to fall back to the paths in CamomileDefaultConfig. If the user tries to access those paths thru CamomileLibraryDefault.Config, then the program will crash if the paths in CamomileDefaultConfig are wrong, even if the custom search procedure would otherwise succeed. This is because the module CamomileLibraryDefault also evaluates a functor, and that fails. (Same thing with CamomileLibraryDyn.)

rgrig commented 12 years ago

This is how I use it: https://github.com/rgrig/barista/blob/master/src/utf8/baristaCamomile.ml

ygrek commented 11 years ago

Please merge this patch.. It is perfectly ok and very useful.