search

yoriyuki / Camomile

A Unicode library for OCaml
Other
125 stars 26 forks source link

Fix 4.05 typing a second time #32

Closed bobot closed 7 years ago

bobot commented 7 years ago

The build of camomile with ocaml 4.05 branch (with the fixes for the future 4.05.1 release) is again broken. These commits add some additional type annotation similar to @gasche ones. It seems to occur since commit a38350d5c02d021657c18a36b56d79ef669f7054 of ocaml (MR ocaml/ocaml#1272).

Even if it is ocaml fault, the modification of camomile is small.

yoriyuki commented 7 years ago

Thank you for a pull request.

Maybe I missed something, but I encounter a build error using ocaml 4.05.0 I think this is related to Uchar module, so probably not related to your pull request. But did you have a same problem, and if so, how you resolve it?

I ask because I want to see your patch don't create a build error on 4.05.0

bobot commented 7 years ago

I think this is related to Uchar module. But did you have a same problem, and if so, how you resolve it?

No I don't have the Uchar problem. But I used directly the source of 4.05.0 and 4.05 not opam in order to test my patch. Are you sure you don't have the same problem with master?

I ask because I want to see your patch don't create a build error on 4.05.0

Of course. The problematic commit in ocaml 4.05 is going to be reverted, but I still think the patch could only help camomile to be more resistant to ocaml typing change.

yoriyuki commented 7 years ago

Thanks, let me look at the Uchar issue first. Even if this is a opam problem, it's still a huge issue.

yoriyuki commented 7 years ago

I found the Uchar issue only occurs when jbuilder is used. Traditional gmake file don' have the problem.

I checked your patch. It built and passed the tests. I will merge the pull request.