search

yoriyuki / Camomile

A Unicode library for OCaml
Other
125 stars 26 forks source link

Add support for 4.02.3 #43

Closed rgrinberg closed 6 years ago

rgrinberg commented 6 years ago

I know @yoriyuki stated that supporting very old versions of OCaml is too costly to maintain, but supporting 4.02.3 turned out to be easy enough with a small series of hacks I made. The reason why I did this is that Camomile is necessary for utop and hence reason which still supports 4.02.3 because of bucklescript. It would be great to restore 4.02.3 compat and make a bugfix release. If in the future, compat with 4.02.3 is broken, then we'll revaluate how hard it would be to support it again. But for now let's make the change a bit more gradual for everyone.

cc @jordwalke

jordwalke commented 6 years ago

Thanks. Reason currently works on all versions we've tested (up to 4.05 IIRC) with all the common opam setups, but we can make it so that Reason still works on 4.02.3 for BuckleScript without a dependency on Camomile by pulling out rtop which we wanted to do anyways. Rtop would then be a 4.04+ package. I am grateful for you fixing 4.02.3 though. Thank you.

yoriyuki commented 6 years ago

Just to ask clarification. Is there any problem using 0.8.5 for ocaml 4.02.3?

rgrinberg commented 6 years ago

@yoriyuki Yes, because the latest version of lambda-term and utop only works with 0.8.6. We still want the 4.02.3 users to have the latest utop for a while longer.

yoriyuki commented 6 years ago

Merged. I’m away home so I cannot test the repo now. I will tag the repo by rel-0.8.7 tomorrow.

rgrinberg commented 6 years ago

@yoriyuki I've tagged a release and will put it on opam. If I missed anything up, let me know!

jordwalke commented 6 years ago

Thank you both.

yoriyuki commented 6 years ago

@rgrinberg Thank you for tagging and the opam patch. We need to change the version number in README and add an entry to changlog. Are they old-fashioned so removing them is better?

rgrinberg commented 6 years ago

We should update the change log definitely. Yeah we don't need the version number in the repo. Git tag is enough

On Fri, Nov 10, 2017, 9:55 PM Yoriyuki Yamagata notifications@github.com wrote:

@rgrinberg https://github.com/rgrinberg Thank you for tagging and the opam patch. We need to change the version number and changlog. Are they old-fashioned so removing them is better?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/yoriyuki/Camomile/pull/43#issuecomment-343479356, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIe--bp3wXAR7AvLxLPydVnQzx9KRQuks5s1FXCgaJpZM4QS9Pd .