search

yoriyuki / Camomile

A Unicode library for OCaml
Other
125 stars 26 forks source link

more helpful exception instead of Not_found when resource is missing #5

Closed ygrek closed 11 years ago

yoriyuki commented 11 years ago

After some rethinking, I decided that this patch will be available in the future release 0.9.0. The reasons are 1) this will introduce the incompatible API, 2) Not_found is raised many places of Camomile, some of which are intentional. We need to check and think throughly for the purpose of consistency.

Therefore, your patch is merged to v0.9.0 branch but reverted in the master and v0.8.5 branch.

I hope that you do not take this as an offense.

ygrek commented 11 years ago

Surely not. Looking forward to the 0.9.0 release.