search

yoriyuki / Camomile

A Unicode library for OCaml
Other
125 stars 26 forks source link

Use jbuilder promote feature instead of ocaml syntax #56

Closed rgrinberg closed 6 years ago

rgrinberg commented 6 years ago

@yoriyuki $ jbuilder build @jbuild --auto-promote to update the jbuild files.

cc @diml

rgrinberg commented 6 years ago

Yup. It's necessary. Promotion is a jbuilder feature for managing generated files in source. The idea is that if the generated file will ever go out of date then the test target will complain.

The reason why we do this is that ocaml syntax jbuild files are basically deprecated. This approach results in faster builds and will not break in the future.

On Mon, Feb 5, 2018, 7:24 AM Yoriyuki Yamagata notifications@github.com wrote:

@yoriyuki commented on this pull request.

You include jbuild.inc. Is it necessary? It appears an automatically generated file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/yoriyuki/Camomile/pull/56#pullrequestreview-93862576, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIe-04vZ0uRR4XYc2ayDwHNNx5-GTxKks5tRjwogaJpZM4R4LYg .

ghost commented 6 years ago

BTW, currently Jbuilder doesn't support including a file generated by a rule. It's a current limitation of the implementation. But we are progressing towards support this. It should be supported at some point this year.