search

yoriyuki / Camomile

A Unicode library for OCaml
Other
125 stars 26 forks source link

Remove support for Dynamic Configuration #58

Closed rgrinberg closed 6 years ago

rgrinberg commented 6 years ago

Configuration using environment variables should no longer be allowed. All the static data that is shipped with Camomile is entirely static and can only be configured at the build time of tue library. Hence CamomileLibraryDyn is just an alias for CamomileLibraryDefault.

As we discussed previously, runtime configuration of this stuff should be removed. I've looked on opam and nobody seems to rely on these environment variables so it's technically not a breaking change.

(cc @diml b/c we'll need to update lambda-term to just use CamomileLibraryDefault directly.)

yoriyuki commented 6 years ago

I agree with removing dynamic configuration. But I want to keep the master compatible to the previous versions. There is a lot of in-house OCaml code which does not appear in opam. So could you PR against v1.0.0 branch instead of the master?