yoriyuki / Camomile

A Unicode library for OCaml
Other
125 stars 26 forks source link

Fix broken jbuild target #60

Closed rgrinberg closed 6 years ago

rgrinberg commented 6 years ago

The target wasn't specifying its dependencies correctly. It should depend on all charmaps/locales (respectively). To express this dependency correctly we need to reshuffle the charmap sources into their own dir for easy globing.

Very sorry about this @yoriyuki, I wasn't supposed to let this go out of date. We really need CI to catch these issues. But for that we need our test suite to pass. I'll have a look at turning the current test failures into "expected failures". Otherwise it's too easy to break stuff accidentally.