search

yoriyuki / Camomile

A Unicode library for OCaml
Other
125 stars 26 forks source link

[WIP] Switch to dune and use include_subdirs #72

Closed ghost closed 6 years ago

ghost commented 6 years ago

I wanted to try the newly added support for multi-directory libraries in dune on a real project, so I converted camomile to dune and tried to use it. The benefit is that it removes all the (rule (copy# ...)) from Camomile/dune. The build is failing so I must have made a typo while converting the jbuild files to dune files. I'll try to come back to this later this week.

rgrinberg commented 6 years ago

This is now working given that you've fixed the bug in dune?

ghost commented 6 years ago

Nope, it's something different. If you try to run make some of the rules don't produce the requested files. I removed a copy_files in one of the jbuild file, I believe it's because of this

ghost commented 6 years ago

I fixed the build, this PR is now ready.