yorkeJohn / Tainted-Magic

Tainted Magic, an addon to Thaumcraft 4
20 stars 26 forks source link

Incorrect focus upgrade being applied #83

Open piedragon12 opened 2 years ago

piedragon12 commented 2 years ago

When ever anyone in the server i run Tries to upgrade the dark matter focus with sanity, diffusion or any other tainted magic specific upgrades it just adds on the nuggets upgrade i have attached my mod list i have no idea what is causing this list.txt

piedragon12 commented 2 years ago

actually after further investigation its any specific tainted magic upgrade

yorkeJohn commented 2 years ago

Thank you for your bug report.

Please verify that the focus upgrade IDs for the Thaumcraft add-ons you have installed are properly configured such that no IDs overlap. Tainted Magic’s upgrade IDs are configurable in the mod’s config file. It is possible that another mod’s focus upgrades are using the same IDs as Tainted Magic’s default configuration, causing the wrong upgrade to be applied.

It would also be helpful to know which mod is adding the focus upgrade which you have reported is getting applied.

Cheers

piedragon12 commented 2 years ago

it is Thaumic Horizons that adds in the upgrade that it switches them to and after changing all the values to ones that aren't being used it wont allow me to apply any of tainted magics specific upgrades they appear but are otherwise nonfunctional

piedragon12 commented 1 year ago

would you happen to know off hand if any other Ids work or if they need to be in any specific order as I've cycled through most of them and it just seems to outright disable the ability to apply any of them now

yorkeJohn commented 1 year ago

Upon inspection this looks like it could be a code bug with how the focus upgrades are initialized. I will look into this more.

yorkeJohn commented 1 year ago

I have been trying to reproduce this issue and I can't seem to get it to happen. Does this issue happen in your modpack when running singleplayer as well? Or only when running multiplayer?

piedragon12 commented 1 year ago

after testing for a few days the behavior remains regardless of what I do in both single and multiplayer

ianlavr commented 1 year ago

still having this issue

upgrading the dark matter focus with sanity turned that upgrade into nuggets along with not causing warp it now also shoots out a diffusion cloud instead of a dark matter ball and seems to cause wither i did not upgrade it with diffusion or corrosion yet only sanity it seems like the upgrade nuggets functions as every tainted magic added upgrade on a focus

hopefully this gets fixed some day

yorkeJohn commented 1 year ago

Unfortunately as far as I can tell, this is an issue with Thaumic Horizons, which is not open source, so I really can't do much to fix this. Possible solutions include removing Thaumic Horizons from your modpack, or contacting the TC mod author for assistance.

yorkeJohn commented 1 year ago

The only other thing that could help would be if you could post your startup log so that I can see if there is any error being reported when loading in the focus upgrades.

ianlavr commented 1 year ago

latest.log

Hopefully this is the thing youre looking for

Also after some testing it seems that this isnt an issue related solely to thaumic horizons With the latest versions of TC, TH, TM and Gadomancy(for convenience) and nothing else. The Dark Matter focus still gets the correct upgrade. It seems that another mod is messing something up along with TH. I wonder how many possible focus upgrade ids are there? 2023-02-27_23 13 21

ianlavr commented 1 year ago

Changing the focus ids to ridiculously high fixed this (atleast for me). Not sure on why I havent done that before

Edit: Nope it didnt. In a creative world it worked but in my survival world it still just turns into nuggets. HOWEVER this seems to be only a graphical glitch.