Add redirection after login

wet6123 commented 2 weeks ago

What this PR does / why we need it:

Store previous page URL before login. Redirect user back to stored URL after successful login. Add default redirect to home page if URL doesn't exists. Until now, Codepair always redirects you to home after login failure. This allows you to redirect to the intended location.

Which issue(s) this PR fixes:

Fixes #308

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Redirect user to previous page after successful login.

Additional documentation:

Checklist:

[x] Added relevant tests or not required
[x] Didn't break anything

Summary by CodeRabbit

New Features
- Enhanced login functionality to support location-based redirection after authentication.
- Improved redirection logic after successful authentication to navigate users to their intended destination.
Bug Fixes
- Fixed the handling of redirect paths to ensure users are directed appropriately post-login.

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes introduced in this pull request enhance the user login flow by implementing location-based redirection. In the Index component, the useLocation hook is utilized to capture the user's intended pathname, which is stored in session storage upon login. The CallbackIndex component is updated to retrieve this redirect path from session storage after authentication, ensuring users are directed to their intended page instead of the root path.

Changes

File	Change Summary
`frontend/src/pages/Index.tsx`	Added `useLocation` import and a constant `location` to capture the pathname for redirection. Updated `handleLogin` to store the redirect path in session storage.
`frontend/src/pages/auth/callback/Index.tsx`	Modified `CallbackIndex` to retrieve the `redirect` path from session storage and navigate to it after setting tokens.

Assessment against linked issues

Objective	Addressed	Explanation
Redirect users to their intended page after login failure (#308)	✅

Possibly related PRs

317: The changes in the CallbackIndex component for handling redirection after authentication are directly related to the modifications in the Index component, which also focuses on managing user login and redirect paths.

Suggested labels

enhancement 🌟

Poem

In the burrow where we hop and play,
A path was lost, but now it's okay.
With every login, we find our way,
To the page we seek, come what may!
Hooray for redirects, let’s cheer and sway! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

wet6123 commented 2 weeks ago

@devleejb Oh, I forgot to mention about the strict mode. I stored the previous URL at the session storage. And then when login success, use the URL and remove it. In strict mode, this code will run twice and the URL will be gone. Then it goes to "/". So, if you disable strict mode, it works fine. Or I can change it not to remove the URL at the session storage. To ensure that it works well even in strict mode.

devleejb commented 2 weeks ago

@wet6123 I believe it should also work well in strict mode. What do you think?

wet6123 commented 1 week ago

@devleejb I think it's better to make it work in strict mode. I can finish it until this weekend.

yorkie-team / codepair