search

yorkie-team / dashboard

Dashboard is an administrative tool that allows users to manage projects and documents with ease.
https://yorkie.dev/dashboard/
Apache License 2.0
20 stars 13 forks source link

Set minimum limit on ClientDeactivateThreshold in project settings #109

Closed krapie closed 1 year ago

krapie commented 1 year ago

What this PR does / why we need it?

Set minimum limit on ClientDeactivateThreshold in project settings by updating regex & description.

There was no minimum value limit on ClientDeactivateThreshold, which may result in excessive client deactivation. For example, if ClientDeactivateThreshold is set to 01s(or any other smaller value than housekeepingInterval), client may deactivate every time housekeeping occurs.

Any background context you want to provide?

Setting minimum value limit on ClientDeactivateThreshold was discussed this comment: https://github.com/yorkie-team/dashboard/pull/107#discussion_r1116645765

What are the relevant tickets?

Fixes #

Checklist

krapie commented 1 year ago

Closed PR by following this comment: https://github.com/yorkie-team/yorkie/pull/477#discussion_r1119741049