Fix time format that cannot distinguish between AM/PM

yorkie-team / dashboard

Dashboard is an administrative tool that allows users to manage projects and documents with ease.

https://yorkie.dev/dashboard/

Apache License 2.0

20 stars 13 forks source link

Fix time format that cannot distinguish between AM/PM #122

Closed g2hhh2ee closed 1 year ago

g2hhh2ee commented 1 year ago

What this PR does / why we need it?

When I selected the 12-hour-format setting, I had the problem of not being able to distinguish AM/PM. So I added the relevant format.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

[x] Added relevant tests or not required
[x] Didn't break anything

CLAassistant commented 1 year ago

All committers have signed the CLA.

g2hhh2ee commented 1 year ago

Also, Yorkie project shows H:mm:ss format in the time setting example, but in document list it only shows H:mm. Can I modify the example code '13:00:00': '01:00:00 PM' to '13:00' : '1:00 PM’?

krapie commented 1 year ago

Thank you for your contribution.

Also, Yorkie project shows H:mm:ss format in the time setting example, but in document list it only shows H:mm. Can I modify the example code '13:00:00': '01:00:00 PM' to '13:00' : '1:00 PM’?

Considering our current time display format of our dashboard UI, it will be nice to unify all time format to hh:mm.

krapie commented 1 year ago

LGTM!