Closed vitran12 closed 3 months ago
[!WARNING]
Review failed
The pull request is closed.
In this update, several icon components were enhanced to improve accessibility, including adding <title>
and aria-label
attributes within their SVG elements. Additionally, the package.json
version was incremented from "0.5.13" to "0.5.14". The Icon.mdx
file saw a change in stroke color values to a consistent black color with varying opacities. Overall, these changes ensure better accessibility and visually consistent icons.
Files (Grouped by Similar Changes) | Change Summary |
---|---|
package.json |
Incremented version number of "yorkie-ui" project from "0.5.13" to "0.5.14". |
src/app/page.tsx |
Added import for IconCopy and used <IconCopy /> within the Home component. |
.../ui/icon/Icon.mdx |
Updated stroke color values to black with varying opacities. |
.../ui/icon/Icon.stories.tsx |
Updated stroke property values for different icon sizes using abstract color notations. |
Various src/components/ui/icons/*.tsx files (e.g., calendar.tsx , check-icon.tsx , close-icon.tsx , etc.) |
Added <title> elements to various icon components for better accessibility. |
Various src/components/ui/icons/*.tsx files (e.g., icon_close_small.tsx , icon_cloud.tsx , icon_package.tsx , etc.) |
Added aria-label attributes to various icon components for better accessibility. |
src/components/ui/icons/icon_copy.tsx |
Significantly updated SVG structure and attributes, including paths, viewBox, width, height, and stroke-width. |
src/components/ui/icons/logo.tsx |
Added aria-labelledby attribute and corresponding <title> element within the SVG for accessibility. |
In the world of code, a rabbit hops,
Adding titles and labels, it never stops.
Icons now clear, for all to see,
Accessibility for you and me.
With version bumped, we proudly say,
Progress made in a rabbit's way!
🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Checklist:
Summary by CodeRabbit
New Features
<IconCopy />
component to the Home page.Accessibility Enhancements
<title>
elements to various SVG icons for improved screen reader support.aria-label
attributes to several SVG icons to enhance accessibility compliance.Style
Version Upgrade