CLAassistant
commented
2 months ago
All committers have signed the CLA.
Closed chacha912 closed 2 months ago
CLAassistant
commented
2 months ago
All committers have signed the CLA.
coderabbitai[bot]
commented
2 months ago [!WARNING]
Rate limit exceeded
@chacha912 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 52 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between caff8a2cbb49f6b85f3c038f83196c61073fccdb and 255c7dddbc439acc020492279eed1f34c8875a74.
The recent changes enhance the Storybook application by refining component documentation and layouts, introducing a new Flex component for improved UI flexibility, and updating configuration files for better responsive design. The overall goal is to streamline the styling process and expand customization options while maintaining a cohesive look and feel across the application.
| Files | Change Summary |
|---|---|
apps/storybook/package.json |
Downgraded @storybook/addon-themes from ^8.2.6 to ^8.2.5. |
apps/storybook/src/stories/button/*.mdx |
Replaced <div> with <Flex> in button stories for better layout control, added note about unimplemented link styles. |
apps/storybook/src/stories/button/Button.stories.tsx |
Updated button stories to utilize Flex for layout, expanded colorPalette from 10 to 14 options, and improved spacing and alignment with new Flex implementation. |
apps/storybook/src/stories/flex/*.mdx |
Introduced documentation for the Flex component, including usage examples and props section. |
packages/core/panda.config.ts |
Added numerous properties for improved styling and layout management, including flexbox and visibility controls. |
packages/core/panda/theme/breakpoints.ts |
Adjusted breakpoint sizes for responsive design; increased md, lg, and xl values, removed 2xl. |
packages/core/panda/theme/semantic-tokens/colors.ts |
New file defining semantic color tokens for a design system. |
packages/core/panda/theme/semantic-tokens/index.ts |
Refactored color token management by importing colors from a separate file, reducing inline complexity. |
packages/core/panda/theme/semantic-tokens/shadows.ts |
Reset shadow definitions to an empty object, removing all previously defined styles. |
packages/core/panda/theme/tokens/z-index.ts |
Added float property to zIndex definition to manage stacking order. |
packages/core/src/flex/*.tsx |
Implemented a new Flex component for flexible layout management, utilizing forwardRef for DOM interaction. |
packages/core/src/index.ts |
Expanded exports to include the new Flex functionality alongside existing button exports. |
sequenceDiagram
participant A as User
participant B as Storybook
participant C as Flex Component
participant D as Button Component
A->>B: Open Storybook
B->>D: Render Button Stories
D->>C: Use Flex for Layout
C->>B: Return Rendered Flex Layout
B->>A: Display Updated Button Stories🐰 In the meadow, hopping free,
A Flex design, what glee to see!
Buttons dance in perfect line,
Colors bright and layout fine.
With every click, my heart takes flight,
Oh, how changes make the world so bright! 🌈✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
What this PR does / why we need it:
I added the static CSS and Flex component because they were needed to replace the button component on the Yorkie Homepage.: https://github.com/yorkie-team/yorkie-team.github.io/pull/155
Special notes for your reviewer:
I added only the necessary styles to the static CSS, but since we can't predict which styles users will use, we might need to prepare all styles in static CSS. This could increase the size and build time, so I'm considering whether to structure the Yorkie UI in a copy-paste format like Park UI or Shadcn UI.
Which issue(s) this PR fixes:
Fixes #
Checklist:
Summary by CodeRabbit
New Features
Flexcomponent for improved flexible layout management.Flexdocumentation page and stories to showcase its capabilities.Bug Fixes
@storybook/addon-themesfor better compatibility.Refactor
Documentation
Flexcomponent, including usage examples and props details.