yorkie-team / yorkie

Yorkie is a document store for collaborative applications.
https://yorkie.dev
Apache License 2.0
761 stars 140 forks source link

Support `yorkie-monitoring` and `yorkie-argocd` Charts on NCP #846

Closed krapie closed 4 months ago

krapie commented 4 months ago

What this PR does / why we need it:

This PR adds support for yorkie-monitoring and yorkie-argocd charts on NCP. Additionally, it addresses a small parsing error in the annotation of alb.ingress.kubernetes.io/ssl-certificate-no by converting the value from number to string.

Which issue(s) this PR fixes:

Fixes #844

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation:

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.81%. Comparing base (5b7c7fb) to head (2b47d52).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #846 +/- ## ======================================= Coverage 50.81% 50.81% ======================================= Files 70 70 Lines 10255 10255 ======================================= Hits 5211 5211 Misses 4516 4516 Partials 528 528 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.