search

yorkie-team / yorkie

Yorkie is a document store for collaborative applications.
https://yorkie.dev
Apache License 2.0
761 stars 140 forks source link

Handle concurrent editing and styling in Tree #854

Closed hackerwins closed 3 months ago

hackerwins commented 3 months ago

What this PR does / why we need it:

Handle concurrent editing and styling in Tree

We will use maxCreatedAtMapByActor until the introduction of VersionVector.

Which issue(s) this PR fixes:

Address #788

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation:

Checklist:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 57.14286% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 50.81%. Comparing base (a82995b) to head (1dea4eb).

Files Patch % Lines
pkg/document/crdt/tree.go 63.26% 17 Missing and 1 partial :warning:
api/converter/to_pb.go 20.00% 8 Missing :warning:
api/converter/from_pb.go 0.00% 7 Missing :warning:
pkg/document/crdt/rga_tree_split.go 80.00% 3 Missing :warning:
pkg/document/crdt/text.go 70.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #854 +/- ## ========================================== - Coverage 50.81% 50.81% -0.01% ========================================== Files 70 70 Lines 10255 10285 +30 ========================================== + Hits 5211 5226 +15 - Misses 4516 4530 +14 - Partials 528 529 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.