coderabbitai[bot]
commented
1 month ago Walkthrough
The recent updates introduce a new boolean flag, SnapshotDisableGC, to control the garbage collection (GC) of snapshots across various components of the system. This flag is propagated through the configuration, document creation, and change application processes, allowing for the selective disabling of GC. Additionally, integration tests have been updated to validate this new functionality.
Changes
| Files | Change Summary |
|---|---|
cmd/yorkie/server.go |
Added a new boolean flag SnapshotDisableGC to control snapshot garbage collection. |
pkg/document/document.go |
Introduced Options struct and WithDisableGC function to configure document setup with DisableGC option. |
pkg/document/internal_document.go |
Updated ApplyChangePack method to accept disableGC parameter. |
server/backend/config.go |
Added SnapshotDisableGC field to Config struct. |
server/config.go |
Added DefaultSnapshotDisableGC constant with value false. |
server/packs/packs.go, server/packs/pushpull.go, server/packs/snapshots.go |
Modified function calls to include SnapshotDisableGC parameter. |
test/integration/gc_test.go |
Added imports and test case for disabling garbage collection based on server configuration. |
🐰 In code we trust, we tweak and mend, With flags to guide, and bugs to end. A toggle here, a switch to see, Disabling GC, our docs run free. Through tests we march, with code so bright, Embracing change, we code the night. 🌙
[!TIP]
New Features and Improvements
## Review Settings Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. ## AST-based Instructions CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the [documentation](https://docs.coderabbit.ai/guides/review-instructions#ast-based). ## Community-driven AST-based Rules We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the [ast-grep-essentials](https://github.com/coderabbitai/ast-grep-essentials) repository for more information. ## New Static Analysis Tools We are continually expanding our support for static analysis tools. We have added support for `biome`, `hadolint`, and `ast-grep`. Update the settings in your `.coderabbit.yaml` file or head over to the settings page to enable or disable the tools you want to use. ## Tone Settings Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples: - Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!" - Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!" - Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!" ## Revamped Settings Page We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to `.coderabbit.yaml` will be reflected in the settings page, and vice versa. ## Miscellaneous - Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the `enable_free_tier` setting. - Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (`local`) or the organization (`global`) level using the `knowledge_base` setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations. - High-level summary placement: You can now customize the location of the high-level summary in the PR description using the `high_level_summary_placeholder` setting (default `@coderabbitai summary`). - Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the `request_changes_workflow` setting.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
What this PR does / why we need it:
Add snapshot-disable-gc flag
GC defects are found for sequence data types such as Array, Text, and Tree. This commit provides the option to temporarily turn off GC on the server.
Which issue(s) this PR fixes:
Related to https://github.com/yorkie-team/yorkie/issues/723
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist:
Summary by CodeRabbit
New Features
Improvements
Tests