yorkie-team / yorkie

Yorkie is a document store for collaborative applications.
https://yorkie.dev
Apache License 2.0
771 stars 143 forks source link

CI workflow doesn't work due to Docker Compose V1 being deprecated on the runner's ubuntu image #949

Closed kokodak closed 1 month ago

kokodak commented 1 month ago

What happened:

Since this PR, docker compose V1 no longer works with ubuntu images in the actions runner. For this reason, there is currently an issue with CI workflow not working properly.

image

What you expected to happen:

The CI workflow should work correctly.

How to reproduce it (as minimally and precisely as possible):

Refer to the Docker documentation for Migrate Compose V2, replacing the commands in compose V1 with the commands in compose V2.

Anything else we need to know?:

This issue can occur in multiple repositories within yorkie-team, not just the yorkie repository.

Environment:

krapie commented 1 month ago

Is this issue occurring every time we perform docker-compose command on Github Actions? I think we need to find which repositories are using docker-compose command and make a checklist below to track it.

kokodak commented 1 month ago

Is this issue occurring every time we perform docker-compose command on Github Actions? I think we need to find which repositories are using docker-compose command and make a checklist below to track it.

In Github Actions, yes.

Elsewhere, Compose V1 will work, but Docker compose V1 has been deprecated since 2021, so it's probably best to move to Compose V2 in most cases.

The only place I've found that uses docker-compose is the ci.yaml in yorkie-js-sdk

kokodak commented 1 month ago

Some of the documentation points to using docker-compose, do we need to change that?

krapie commented 1 month ago

@kokodak Yes. I think it is time to update everything to docker compose V2.

fourjae commented 1 month ago

In #950 PR, the main CONTRIBUTING.md and docker README.md files were modified. Is there anything else that needs to be modified?

krapie commented 1 month ago

@fourjae I think yorkie repository is up to date. I have checked the occurrence of the word docker-compose -f. Could you re-check it to see if there are anything that we have omitted?

kokodak commented 1 month ago

I will work on the Compose V1 issue in the yorkie-js-sdk repository.

fourjae commented 1 month ago

@krapie I think the docker-compose -f command no longer exists in all files of the yorkie server project.