search

yorklim / pe

0 stars 0 forks source link

add_student bug: Email follows instructions but unable to add student #5

Open yorklim opened 5 months ago

yorklim commented 5 months ago

I am unable to add the student with the email "Za-----ck@example.com" even though it follows the email format provided by the error message.

image.png

Step to Reproduce:

  1. enter command "/add_student name/Zack id/A1234567Z email/Za----ck@example.com tag/Student"
nus-pe-script commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add email with special characters that are allowed

image.png

As seen in the image, when attempting to add /add_student name/Dohn Joe email/john+_.-doe@gmail.com id/A0123456A, we get an error message.

The input seems to be perfectly fine according the error message:

Emails should be of the format local-part@domain and adhere to the following constraints:

  1. The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). The local-part may not start or end with any special characters.
  2. This is followed by a '@' and then a domain name. The domain name is made up of domain labels separated by periods. The domain name must:
    • end with a domain label at least 2 characters long
    • have each domain label start and end with alphanumeric characters
    • have each domain label consist of alphanumeric characters, separated only by hyphens, if any.

Except maybe the last part which says "have each domain label consist of alphanumeric characters, separated only by hyphens, if any."

But that is a different bug altogether and is contradictory to what's mentioned in point 1 - The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). The local-part may not start or end with any special characters.

[original: nus-cs2103-AY2324S2/pe-interim#5367] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Alphanumeric characters and certain special characters only allowed, EXCLUDING the mentioned special characters

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** According to the error message, The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). Which means that alphanumeric characters, +, _, . and - are allowed which is contrary to what was mentioned by the team.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** This is a functionality bug as the stated behavior of allowing alphanumeric characters, +, _, . and - within the local-part was not followed and thus cannot be considered a feature flaw.
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]