search

yorklim / pe

0 stars 0 forks source link

Error message of add_student is not specific enough #6

Open yorklim opened 5 months ago

yorklim commented 5 months ago

It seems like two students cannot have the same email and student ID, so when adding a student with the same email or student ID and error is given. However, error message given is not specific and is the same for both scenarios, whether the error is in the student ID or email.

This will result in the user not being able to figure out what is wrong with the command they entered as they will not know what to fix.

image.png

image.png

Steps to reproduce:

  1. Enter "/add_student name/Zack2 id/A4234567Z email/zack@example.com tag/Student "
  2. Error "already exists in the address book!" is given
  3. Enter "/add_student name/Zack2 id/A4234567Z email/zack@example.com tag/Student "
  4. Same error is given
nus-se-script commented 5 months ago

Team's Response

Detailed in planned enhancement.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]