Fix Chrome document.execCommand('Copy') - Githubissues

yorkxin / copy-as-markdown

A browser extension to copy tabs and links as Markdown

MIT License

529 stars 81 forks source link

Fix Chrome document.execCommand('Copy') #112

Closed yorkxin closed 1 year ago

yorkxin commented 1 year ago

Summary

chrome.scripting.executeScript does not handle promise reject, so invent a custom protocol to return error from content script.
the correct way to set textarea's content is innerHTML=, not value=.

Tests

[x] Chrome stable (macOS)
[x] Firefox stable (macOS)
[ ] Chrome stable (Windows)
[ ] Firefox stable (Windows)

Optional:

[ ] Chrome beta (macOS)
[ ] Firefox beta (macOS)
[ ] Chrome beta (Windows)
[ ] Firefox beta (Windows)