yorkxin / copy-as-markdown

A browser extension to copy tabs and links as Markdown
MIT License
546 stars 83 forks source link

Use dash for unordered lists #126

Closed andreoliwa closed 7 months ago

andreoliwa commented 7 months ago

Summary

Change the unordered list bullet from asterisk (*) to dash (-).

Why?

  1. Prettier formats Markdown with dashes, see https://github.com/prettier/prettier/issues/4251
  2. Logseq also uses dashes for unordered lists. Pasting multiple links with asterisks is not recognized as a list by Logseq.

I'm aware that the specs allow both of them though:

Tests

I use Brave Browser, which is Chromium-compatible and can use Chrome extensions.

So I only tested on this one.

Optional:

yorkxin commented 7 months ago

Thanks. I also noticed that I am using - in the release notes.

However since this is a change of default behavior, I'd like to add an option so that users can choose which syntax to use. I will merge your changes and introduce another patch that implements the options UI.

yorkxin commented 7 months ago

This change has been shipped to Chrome Web Store, Edge Add-Ons and Firefox Add-Ons!