search

yortus / asyncawait

Callback heaven for Node.js with async/await
MIT License
1.91k stars 77 forks source link

Upgrade fibers package for nodejs 10.x or 12.x #74

Closed iTechDhaval closed 4 years ago

iTechDhaval commented 5 years ago

I looked at fibers README and they have mentioned different versions of fibers for different nodejs versions.

What do you suggest best possible way to accommodate this dependancy restriction for asyncawait package?

yortus commented 5 years ago

I think just make a PR upgrading the fibers dependency to v4, and bumping asyncawait's version to 3.0.0.

If in future anybody needs something to work with node 8.x (which I doubt since nobody has raised it so far), then there's still the possibility to release a version 2.0.0 that uses fibers@3.

iTechDhaval commented 5 years ago

Perfect. I will do it.

nitin-35 commented 4 years ago

Is there a release planned for this?

I tried updating to node 12.x but failed due to this fibers issue. Works fine on node 10.x currently.

iTechDhaval commented 4 years ago

@nitin-synapptra i had to generate pull request. I will do it asap.

iTechDhaval commented 4 years ago

@yortus can you please merge #75 to support this task?

yortus commented 4 years ago

I've just merged #75 and published the new version of this package to npm. Thanks again @iTechDhaval.