search

yorukot / superfile

Pretty fancy and modern terminal file manager
https://superfile.netlify.app
MIT License
5.56k stars 126 forks source link

Flashing when switching between panels #122

Open Kadrian opened 4 months ago

Kadrian commented 4 months ago

Love superfile, thank you for the great work!!

Describe the bug Flashing when switching between panels.

To Reproduce Steps to reproduce the behavior:

  1. Use a light themed terminal
  2. Open spf
  3. hit b and m and occasionally, observe the flashes

Expected behavior No flashing

Screenshots

https://github.com/MHNightCat/superfile/assets/1403093/e780f87d-ea85-4939-91f2-7a13b652caf5

System information (please complete the following information):

yorukot commented 4 months ago

I think that's a little hard to fix...

r00tc0d3 commented 4 months ago

Using Zellij it is even worse. It flickers (flashes) with every cursor move. If superfile is a serious tool to consider this must be fixed.

yorukot commented 3 months ago

I do have this problem when I use zellij, but it doesn't seem to happen when I don't. zellij: https://github.com/yorukot/superfile/assets/107802416/1f440a1c-dc57-4245-83e7-56ce30a326c5 no zellij: https://github.com/yorukot/superfile/assets/107802416/48fd5ae8-4e95-4e57-baa3-487af589c0fa

Here's a simple program from bubbletea that I used to test it (just to make sure it's not a performance issue with superfile). https://github.com/yorukot/superfile/assets/107802416/b82f78de-6b65-4c51-991e-c8d86aa9008c

In my opinion, this is a bubbletea issue. I will create an issue in the bubbletea repository!