Update image_preview.go

yorukot / superfile

Pretty fancy and modern terminal file manager

https://superfile.netlify.app

MIT License

5.66k stars 126 forks source link

Update image_preview.go #367

Closed JassonCordones closed 2 weeks ago

JassonCordones commented 2 weeks ago

Added Error handling in hexToColor function.
The ConvertImageToANSI function now uses colorToTermenv for all color conversions.
Simplified the background color handling in ConvertImageToANSI.
colorToTermenv function now takes a fallback color string, making it more flexible.
Added error checking for the background color in ImagePreview.

netlify[bot] commented 2 weeks ago

Deploy Preview for superfile ready!

Name	Link
Latest commit	0361e02780621fdcbd6bf05c3544e0701b74d323
Latest deploy log	https://app.netlify.com/sites/superfile/deploys/66e142bafb018e0007d5fe59
Deploy Preview	https://deploy-preview-367--superfile.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yorukot commented 2 weeks ago

Hey, thanks a lot for your PR, really appreciate your contribution! 🙏 However, I noticed an issue after reviewing the updated version.

In the new version (on the right), it seems like the background of the PNG file is no longer transparent, which affects the visual appearance of the image.

JassonCordones commented 2 weeks ago

I just pushed a fix, please check

yorukot commented 2 weeks ago

I've committed some changes to address the issue. Could you please review them and let me know if everything looks good to you?

yorukot / superfile

Update image_preview.go #367

✅ Deploy Preview for superfile ready!

Deploy Preview for superfile ready!