yorukot / superfile

Pretty fancy and modern terminal file manager
https://superfile.netlify.app
MIT License
7.54k stars 167 forks source link

Hotkey `v`: selection mode #474

Open knqti opened 2 days ago

knqti commented 2 days ago

Describe the bug Pressing v doesn't toggle the selection mode.

To Reproduce Steps to reproduce the behavior:

  1. Launch superfile with spf in terminal
  2. Press v

Expected behavior Selection mode should toggle on.

Screenshots

System information (please complete the following information):

yorukot commented 1 day ago

I just tested this and this only happens in 1.1.5. I think version 1.1.5 has some big issues.

yorukot commented 1 day ago

https://github.com/yorukot/superfile/releases/tag/v1.1.6 I release this version to fix this very issue.

More details: Default configuration file in 1.1.5 is the wrong configuration file, As a result, the hotkeys set by default are different from the actual ones.

emulsion-io commented 1 day ago

change_panel_mode = v is now ok for me.

but ctrl+v, doesn't work. If I change for ctrl+b is ok...

yorukot commented 1 day ago

@emulsion-io would you mind post your hotkeys.toml? thanks!

emulsion-io commented 1 day ago

@emulsion-io would you mind post your hotkeys.toml? thanks!

# Global hotkeys (cannot conflict with other hotkeys)
confirm = ['enter', 'right', 'l']
quit = ['q', 'esc']
# movement
list_up = ['up', 'k']
list_down = ['down', 'j']
# file panel control
create_new_file_panel = ['n', '']
close_file_panel = ['w', '']
next_file_panel = ['tab', 'L']
previous_file_panel = ['shift+left', 'H']
toggle_file_preview_panel = ['f', '']
open_sort_options_menu = ['o', '']
toggle_reverse_sort = ['R', '']
# change focus
focus_on_process_bar = ['p', '']
focus_on_sidebar = ['s', '']
focus_on_metadata = ['m', '']
# create file/directory and rename
file_panel_item_create = ['ctrl+n', '']
file_panel_item_rename = ['ctrl+r', '']
# file operations
copy_items = ['ctrl+c', '']
cut_items = ['ctrl+x', '']
paste_items = ['ctrl+v', '']
delete_items = ['ctrl+d', 'delete', '']
# compress and extract
extract_file = ['ctrl+e', '']
compress_file = ['ctrl+a', '']
# editor
open_file_with_editor = ['e', '']
open_current_directory_with_editor = ['E', '']
# other
pinned_directory = ['P', '']
toggle_dot_file = ['.', '']
change_panel_mode = ['v', '']
open_help_menu = ['?', '']
open_command_line = [':', '']
copy_path = ['ctrl+p', '']
# =================================================================================================
# Typing hotkeys (can conflict with all hotkeys)
confirm_typing = ['enter', '']
cancel_typing = ['ctrl+c', 'esc']
# =================================================================================================
# Normal mode hotkeys (can conflict with other modes, cannot conflict with global hotkeys)
parent_directory = ['h', 'left', 'backspace']
search_bar = ['/', '']
# =================================================================================================
# Select mode hotkeys (can conflict with other modes, cannot conflict with global hotkeys)
file_panel_select_mode_items_select_down = ['shift+down', 'J']
file_panel_select_mode_items_select_up = ['shift+up', 'K']
file_panel_select_all_items = ['A', '']
knqti commented 1 day ago

After updating to v1.1.6, my hotkeys.toml was missing v in: change_panel_mode = ['ctrl+L', ' '].

It works now after I added it in: change_panel_mode = ['ctrl+L', 'v'].

yorukot commented 16 hours ago

I tried the same settings as you and it seems to be no problem at all. Can you try using different terminals?

emulsion-io commented 9 hours ago

Hi,

I try with Putty, no problem,

I find why not work in PowerShell,

image

If I delete this shortcut, is ok on SPF.